FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Add buf-reuse opt-option and rcompile caching by FabioLuporini · Pull Request #2674 · devitocodes/devito · GitHub

/ devito Public

compiler: Add buf-reuse opt-option and rcompile caching - #2674

Merged
mloubout merged 2 commits into
mainfrom
min-buffer-mem
Jul 22, 2025
ConversationCommits (2)ChecksFiles changed
Merged

compiler: Add buf-reuse opt-option and rcompile caching#2674
mloubout merged 2 commits into
mainfrom
min-buffer-mem

Conversation

FabioLuporini commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

No description provided.

codecov Bot commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 87.30159% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (822f146) to head (4d4758d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
devito/passes/clusters/buffering.py 78.78% 5 Missing and 2 partials ⚠️
devito/operator/operator.py 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2674      +/-   ##
==========================================
+ Coverage   87.66%   91.34%   +3.67%     
==========================================
  Files         245      245              
  Lines       49024    49082      +58     
  Branches     4313     4321       +8     
==========================================
+ Hits        42979    44835    +1856     
+ Misses       5310     3530    -1780     
+ Partials      735      717      -18
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 72.52% <36.73%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout approved these changes Jul 21, 2025
View reviewed changes

mloubout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor comment

Comment thread devito/operator/operator.py Outdated
EdCaunt reviewed Jul 21, 2025
View reviewed changes
Comment thread devito/operator/operator.py Outdated
self.exprs = exprs
self.cls = cls

# NOTE: Constructed lazyly at `__call__` time because `**kwargs` is

EdCaunt Jul 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Typo: "lazily"

FabioLuporini Jul 22, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixed

Comment thread tests/test_buffering.py
assert np.all(u.data == u1.data)


def test_buffer_reuse():

EdCaunt Jul 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is it worth also having a test to make sure that non-reusable buffers don't get reused, even when this option is enabled?

FabioLuporini Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

most tests already cover that in PRO

mloubout merged commit b54ca3f into main Jul 22, 2025
35 of 38 checks passed
mloubout deleted the min-buffer-mem branch July 22, 2025 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mloubout mloubout approved these changes
EdCaunt EdCaunt approved these changes

Assignees

No one assigned

Labels

bug-performance-C

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL