FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: isolate GPU runners, respect CUDA_VISIBLE_DEVICES, drop global prunes by ggorman · Pull Request #2680 · devitocodes/devito · GitHub

/ devito Public

ci: isolate GPU runners, respect CUDA_VISIBLE_DEVICES, drop global prunes - #2680

Merged
mloubout merged 6 commits into
mainfrom
parallel-runners-v100
Jul 24, 2025
ConversationCommits (6)ChecksFiles changed
Merged

ci: isolate GPU runners, respect CUDA_VISIBLE_DEVICES, drop global prunes#2680
mloubout merged 6 commits into
mainfrom
parallel-runners-v100

Conversation

ggorman commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

ci: isolate GPU runners, respect CUDA_VISIBLE_DEVICES, drop global prunes

  • Pass CUDA_VISIBLE_DEVICES and use --gpus "device=${CUDA_VISIBLE_DEVICES:-all}" for NVIDIA jobs
  • Tag images/containers with ${{ runner.name }} to avoid cross-runner collisions
  • Remove docker system prune on shared nvidiagpu hosts (keep cache, avoid races)
  • Add runner label to NVIDIA base builds for traceable cleanup
  • Minor YAML tidy/comments across workflows

ci: isolate GPU runners, respect CUDA_VISIBLE_DEVICES, drop global pr…
b1fa43a 
…unes

* Pass CUDA_VISIBLE_DEVICES and use --gpus "device=${CUDA_VISIBLE_DEVICES:-all}" for NVIDIA jobs
* Tag images/containers with ${{ runner.name }} to avoid cross-runner collisions
* Remove docker system prune on shared nvidiagpu hosts (keep cache, avoid races)
* Add runner label to NVIDIA base builds for traceable cleanup
* Minor YAML tidy/comments across workflows
ggorman requested a review from Copilot July 23, 2025 14:38
Copilot AI reviewed Jul 23, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR improves CI pipeline isolation and GPU resource management for Docker-based GPU testing workflows. The changes ensure proper GPU device isolation between concurrent runners and eliminate potential race conditions in shared GPU environments.

  • Implements proper CUDA_VISIBLE_DEVICES handling and Docker GPU device isolation for NVIDIA jobs
  • Adds per-runner tagging for images and containers to prevent cross-runner conflicts
  • Removes global Docker cleanup operations that could interfere with concurrent jobs

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/pytest-gpu.yml Updated GPU test workflow with runner-specific naming, CUDA device isolation, and removed global prunes
.github/workflows/docker-devito.yml Added per-runner container naming and conditional cleanup for non-GPU runners
.github/workflows/docker-bases.yml Standardized quote styles, removed global cleanups, and added runner labels to NVIDIA builds

Comment thread .github/workflows/docker-devito.yml Outdated
Comment thread .github/workflows/docker-devito.yml Outdated
ggorman and others added 2 commits July 23, 2025 15:39
Update .github/workflows/docker-devito.yml
8b8f17e 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update .github/workflows/docker-devito.yml
3b77571 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mloubout approved these changes Jul 23, 2025
View reviewed changes

mloubout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks sane

codecov Bot commented Jul 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.13%. Comparing base (454a8d0) to head (63b4a09).
Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (454a8d0) and HEAD (63b4a09). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (454a8d0) HEAD (63b4a09)
16 12
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
- Coverage   91.34%   84.13%   -7.22%     
==========================================
  Files         245      245              
  Lines       49082    49082              
  Branches     4321     4321              
==========================================
- Hits        44835    41296    -3539     
- Misses       3530     7027    +3497     
- Partials      717      759      +42
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 72.50% <ø> (-0.02%) ⬇️
pytest-gpu-nvc-nvidiaX 73.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout added the CI continuous integration label Jul 24, 2025
mloubout merged commit 444a442 into main Jul 24, 2025
38 of 39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
mloubout mloubout approved these changes

Assignees

mloubout

Labels

CI continuous integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL