FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: Set CONTAINER_NAME within a step. by ggorman · Pull Request #2684 · devitocodes/devito · GitHub

/ devito Public

ci: Set CONTAINER_NAME within a step. - #2684

Merged
FabioLuporini merged 2 commits into
mainfrom
parallel-runners-v100
Jul 25, 2025
ConversationCommits (2)ChecksFiles changed
Merged

ci: Set CONTAINER_NAME within a step.#2684
FabioLuporini merged 2 commits into
mainfrom
parallel-runners-v100

Conversation

ggorman commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

ggorman requested a review from Copilot July 24, 2025 13:42
Copilot AI reviewed Jul 24, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR moves the CONTAINER_NAME environment variable definition from the job-level environment to a runtime step to ensure proper variable resolution. The change addresses an issue where the runner name variable wasn't being properly resolved when defined at the job level.

  • Moves CONTAINER_NAME from job-level env to a dedicated step that sets it dynamically
  • Changes from ${{ runner.name }} to $RUNNER_NAME for proper environment variable resolution

Comment thread .github/workflows/docker-devito.yml

codecov Bot commented Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (a487058) to head (3e55058).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2684      +/-   ##
==========================================
+ Coverage   91.47%   92.01%   +0.53%     
==========================================
  Files         245      245              
  Lines       49093    49093              
  Branches     4322     4322              
==========================================
+ Hits        44909    45171     +262     
+ Misses       3472     3219     -253     
+ Partials      712      703       -9
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 72.51% <ø> (?)
pytest-gpu-nvc-nvidiaX 73.56% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout added the CI continuous integration label Jul 24, 2025
mloubout force-pushed the parallel-runners-v100 branch from 5e79a5a to e71d4e5 Compare July 24, 2025 19:01
FabioLuporini merged commit b57aa00 into main Jul 25, 2025
36 checks passed
FabioLuporini deleted the parallel-runners-v100 branch July 25, 2025 07:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
mloubout mloubout approved these changes
EdCaunt EdCaunt approved these changes

Assignees

No one assigned

Labels

CI continuous integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL