FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Pass the whole descriptor to buf_reuse cbk by FabioLuporini · Pull Request #2687 · devitocodes/devito · GitHub

/ devito Public

compiler: Pass the whole descriptor to buf_reuse cbk - #2687

Merged
FabioLuporini merged 1 commit into
mainfrom
fixup-bitcomp-mystery
Jul 25, 2025
ConversationCommits (1)ChecksFiles changed
Merged

compiler: Pass the whole descriptor to buf_reuse cbk#2687
FabioLuporini merged 1 commit into
mainfrom
fixup-bitcomp-mystery

Conversation

FabioLuporini commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

No description provided.

mloubout approved these changes Jul 25, 2025
View reviewed changes

mloubout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not sure such a big change without a test is acceptable 😄

JDBetteridge approved these changes Jul 25, 2025
View reviewed changes

JDBetteridge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Obviously a battery of tests are needed! I agree with Mathias 😅

codecov Bot commented Jul 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.32%. Comparing base (a487058) to head (d2eab2a).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
devito/passes/clusters/buffering.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2687      +/-   ##
==========================================
- Coverage   91.47%   91.32%   -0.16%     
==========================================
  Files         245      245              
  Lines       49093    49093              
  Branches     4322     4322              
==========================================
- Hits        44909    44835      -74     
- Misses       3472     3538      +66     
- Partials      712      720       +8
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 72.51% <0.00%> (?)
pytest-gpu-nvc-nvidiaX ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FabioLuporini merged commit 358d047 into main Jul 25, 2025
37 of 39 checks passed
FabioLuporini deleted the fixup-bitcomp-mystery branch July 25, 2025 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mloubout mloubout approved these changes
EdCaunt EdCaunt approved these changes
JDBetteridge JDBetteridge approved these changes

Assignees

No one assigned

Labels

compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL