FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Enhance Array codegen by FabioLuporini · Pull Request #2728 · devitocodes/devito · GitHub

/ devito Public

compiler: Enhance Array codegen - #2728

Merged
mloubout merged 6 commits into
mainfrom
simplify-queue-dim-reuse
Sep 9, 2025
ConversationCommits (6)ChecksFiles changed
Merged

compiler: Enhance Array codegen#2728
mloubout merged 6 commits into
mainfrom
simplify-queue-dim-reuse

Conversation

FabioLuporini commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

No description provided.

mloubout reviewed Sep 5, 2025
View reviewed changes
Comment thread tests/test_iet.py
Comment thread tests/test_iet.py

codecov Bot commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.13%. Comparing base (a5193e2) to head (ac68597).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
devito/ir/iet/nodes.py 25.00% 4 Missing and 2 partials ⚠️
devito/arch/compiler.py 25.00% 3 Missing ⚠️
devito/ir/iet/visitors.py 75.00% 2 Missing and 1 partial ⚠️
devito/types/array.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
- Coverage   92.15%   92.13%   -0.02%     
==========================================
  Files         248      248              
  Lines       49995    50022      +27     
  Branches     4401     4402       +1     
==========================================
+ Hits        46072    46088      +16     
- Misses       3213     3223      +10     
- Partials      710      711       +1
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 70.90% <28.57%> (-0.02%) ⬇️
pytest-gpu-nvc-nvidiaX 71.87% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

EdCaunt reviewed Sep 5, 2025
View reviewed changes

EdCaunt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What's this change in response to?

mloubout reviewed Sep 5, 2025
View reviewed changes
Comment thread devito/arch/compiler.py Outdated
mloubout reviewed Sep 5, 2025
View reviewed changes
Comment thread devito/arch/compiler.py Outdated
FabioLuporini force-pushed the simplify-queue-dim-reuse branch from 13bd711 to a4089bd Compare September 8, 2025 10:18

review-notebook-app Bot commented Sep 8, 2025

Copy link
Copy Markdown

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

FabioLuporini force-pushed the simplify-queue-dim-reuse branch from a4089bd to 563a853 Compare September 8, 2025 13:05
mloubout force-pushed the simplify-queue-dim-reuse branch from 662e2ed to ac68597 Compare September 9, 2025 00:24
mloubout merged commit 5111506 into main Sep 9, 2025
36 checks passed
mloubout deleted the simplify-queue-dim-reuse branch September 9, 2025 03:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

EdCaunt EdCaunt left review comments
mloubout mloubout approved these changes

Assignees

No one assigned

Labels

compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL