api: fix arg processing for conditon+factor - #2736
Conversation
Sorry, something went wrong.
Codecov Report❌ Patch coverage is 88.23529% with 6 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #2736 +/- ##
=======================================
Coverage 82.95% 82.96%
=======================================
Files 248 248
Lines 50078 50126 +48
Branches 4409 4415 +6
=======================================
+ Hits 41543 41585 +42
- Misses 7782 7787 +5
- Partials 753 754 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
| if dim.uses_symbolic_factor: | ||
| factor = defaults[dim.symbolic_factor.name] = self.factor_data | ||
| defaults[dim.parent.max_name] = range(0, factor*size - 1) | ||
| if dim.condition is not None: |
There was a problem hiding this comment.
nitpicking, this could be become:
if dim.condition is None:
d0 = 0
d1 = sympy.S.Infinity
else:
d0 = relational_min(...)
d1 = rel ...
then a blank line
then
if d1 < sympy.S.Infinity:
...
Sorry, something went wrong.
| d0 = relational_min(dim.condition, dim.parent) | ||
| d1 = relational_max(dim.condition, dim.parent) | ||
| if d1 < sympy.S.Infinity: | ||
| # We make sure the condtion size matches the input size |
There was a problem hiding this comment.
no defaults set in this branch?
Sorry, something went wrong.
There was a problem hiding this comment.
It will return defaults at the bottom in that case just not set defaults[dim.parent.max_name]
Sorry, something went wrong.
|
|
||
| @_relational_max.register(sympy.And) | ||
| def _(expr, s): | ||
| print([_relational_max(e, s) for e in expr.args]) |
There was a problem hiding this comment.
leftover
Sorry, something went wrong.
No description provided.