FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Avoid premature expansion of avg just like derivs by FabioLuporini · Pull Request #2750 · devitocodes/devito · GitHub

/ devito Public

compiler: Avoid premature expansion of avg just like derivs - #2750

Merged
FabioLuporini merged 1 commit into
mainfrom
change-eval-deriv-behaviour
Oct 2, 2025
ConversationCommits (1)ChecksFiles changed
Merged

compiler: Avoid premature expansion of avg just like derivs#2750
FabioLuporini merged 1 commit into
mainfrom
change-eval-deriv-behaviour

Conversation

FabioLuporini commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

FabioLuporini requested a review from mloubout October 1, 2025 09:42
EdCaunt approved these changes Oct 1, 2025
View reviewed changes

EdCaunt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Uncontroversial I think. Would it be worth having a test to check that expansion isn't being done prematurely?

codecov Bot commented Oct 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.06%. Comparing base (764b075) to head (0f3f70d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2750   +/-   ##
=======================================
  Coverage   83.05%   83.06%           
=======================================
  Files         248      248           
  Lines       50294    50294           
  Branches     4426     4426           
=======================================
+ Hits        41773    41775    +2     
+ Misses       7763     7762    -1     
+ Partials      758      757    -1
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.75% <50.00%> (ø)
pytest-gpu-nvc-nvidiaX 69.28% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout reviewed Oct 1, 2025
View reviewed changes
Comment thread devito/types/basic.py Outdated
retval = SafeInv(retval.evaluate, self.function)
else:
retval = retval.evaluate
retval = retval._evaluate(**kwargs)

mloubout Oct 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What about the evaluate above?

FabioLuporini Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

oh right

FabioLuporini commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

Would it be worth having a test to check that expansion isn't being done prematurely?

I wouldn't know how to excite this code path (as in I would have to find out), but it's imho not so critical

FabioLuporini force-pushed the change-eval-deriv-behaviour branch from 0ea81c4 to 0f3f70d Compare October 1, 2025 12:45
FabioLuporini merged commit e8b621f into main Oct 2, 2025
36 checks passed
FabioLuporini deleted the change-eval-deriv-behaviour branch October 2, 2025 07:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mloubout mloubout approved these changes
EdCaunt EdCaunt approved these changes

Assignees

No one assigned

Labels

compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL