FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Enhance Dereference by FabioLuporini · Pull Request #2762 · devitocodes/devito · GitHub

/ devito Public

compiler: Enhance Dereference - #2762

Merged
FabioLuporini merged 1 commit into
mainfrom
dereference-expr
Oct 13, 2025
ConversationCommits (1)ChecksFiles changed
Merged

compiler: Enhance Dereference#2762
FabioLuporini merged 1 commit into
mainfrom
dereference-expr

Conversation

FabioLuporini commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

No description provided.

codecov Bot commented Oct 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.06%. Comparing base (6139faa) to head (75c80d8).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
devito/ir/iet/nodes.py 50.00% 1 Missing and 1 partial ⚠️
devito/ir/iet/visitors.py 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
+ Coverage   83.05%   83.06%   +0.01%     
==========================================
  Files         248      248              
  Lines       50438    50452      +14     
  Branches     4437     4439       +2     
==========================================
+ Hits        41890    41909      +19     
+ Misses       7789     7783       -6     
- Partials      759      760       +1
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.73% <9.09%> (-0.02%) ⬇️
pytest-gpu-nvc-nvidiaX 69.28% <9.09%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

EdCaunt approved these changes Oct 13, 2025
View reviewed changes

EdCaunt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One tiny nitpick on the test, otherwise looks good to me.

Comment thread tests/test_iet.py
dim1 = CustomDimension(name='d1', symbolic_size=3)
x = Array(name='x', dimensions=(dim0, dim1), dtype=np.float32)

deref = Dereference(x, ptr, offset=off)

EdCaunt Oct 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is there any case where you could have a static offset (i.e. off = 3)?

FabioLuporini Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I cannot see one today, but as long as it's a sympy.Number it'd create no problems

FabioLuporini merged commit c74a3c1 into main Oct 13, 2025
36 checks passed
FabioLuporini deleted the dereference-expr branch October 13, 2025 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mloubout mloubout approved these changes
EdCaunt EdCaunt approved these changes

Assignees

No one assigned

Labels

compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL