FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

misc: Un-cargo-cult switchenv by JDBetteridge · Pull Request #2769 · devitocodes/devito · GitHub

/ devito Public

misc: Un-cargo-cult switchenv - #2769

Merged
FabioLuporini merged 2 commits into
mainfrom
JDBetteridge/remove_switchenv
Oct 17, 2025
ConversationCommits (2)ChecksFiles changed
Merged

misc: Un-cargo-cult switchenv#2769
FabioLuporini merged 2 commits into
mainfrom
JDBetteridge/remove_switchenv

Conversation

JDBetteridge commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

No description provided.

codecov Bot commented Oct 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.95238% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.06%. Comparing base (3169bb5) to head (ab31741).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
devito/parameters.py 76.66% 6 Missing and 1 partial ⚠️
tests/test_gpu_common.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2769      +/-   ##
==========================================
+ Coverage   83.04%   83.06%   +0.01%     
==========================================
  Files         248      248              
  Lines       50469    50481      +12     
  Branches     4440     4439       -1     
==========================================
+ Hits        41913    41930      +17     
+ Misses       7795     7793       -2     
+ Partials      761      758       -3
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.73% <76.47%> (+<0.01%) ⬆️
pytest-gpu-nvc-nvidiaX 69.26% <76.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FabioLuporini approved these changes Oct 17, 2025
View reviewed changes

FabioLuporini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

uncontroversial

JDBetteridge commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

Any ideas what's going on in that one notebook?

mloubout commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

Any ideas what's going on in that one notebook?

For some reason, once in a blue moon, sympy completely collapses and fails the linsolve for an unknown reason.

FabioLuporini merged commit 9d2e0c4 into main Oct 17, 2025
38 of 39 checks passed
FabioLuporini deleted the JDBetteridge/remove_switchenv branch October 17, 2025 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

FabioLuporini FabioLuporini approved these changes
mloubout mloubout approved these changes
EdCaunt EdCaunt approved these changes

Assignees

No one assigned

Labels

bug-py-minor misc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL