| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report❌ Patch coverage is 77.71976% with 256 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #2771 +/- ##
==========================================
- Coverage 83.02% 78.97% -4.05%
==========================================
Files 248 248
Lines 51075 50821 -254
Branches 4492 4391 -101
==========================================
- Hits 42403 40137 -2266
- Misses 7901 9881 +1980
- Partials 771 803 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
| # But ignore these inconvenient rules | ||
| ignore = ["F403", "E226", "E731", "E275", "F405", "E722", "E741", "W605"] | ||
|
|
||
| [tool.isort] |
There was a problem hiding this comment.
you look back 10 years ago or so there's a commit with message "FREEEEEEEEEEEEEDOOOMM" in which we are essentially removing isort from devito 😂
Sorry, something went wrong.
There was a problem hiding this comment.
What was the motivation for removing?
Sorry, something went wrong.
| [tool.isort] | ||
| line_length = 90 | ||
| known_first_party = ["devito", "examples"] | ||
| multi_line_output = "VERTICAL_GRID_GROUPED" |
There was a problem hiding this comment.
if this is for
from X import (
A,
B,
C,
...
)
then I vote no
Sorry, something went wrong.
There was a problem hiding this comment.
No this is in direct response to your comment on my other PR. This is specifically to avoid using ruff for the import formatting (see this issue)
Sorry, something went wrong.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sorry, something went wrong.
|
This is almost ready, it doesn't look like it, but I will merge these two auxiliary branches in once I've tidied the commits and the second is green... |
Sorry, something went wrong.
This reverts commit 1318b52.
Co-authored-by: Ed Caunt <ed@devitocodes.com>
| Back | FazBrowse Home | New Git URL |
I'm trying to automate detection a lot of the "nitpick" code review comments and providing a route to automatically fixing the issues apriori.
What I have added to CI is equivalent to locally running:
isort --check-only --sort-reexports --multi-line VERTICAL_GRID_GROUPED --line-length 90 --force-alphabetical-sort-within-sections --project devito,examples . ruff check --preview --select E,W,F,B,UP,SIM,I,RUF022 --ignore F403,E226,E731,E275,F405,E722,E741,W605 --line-length=90 --output-format conciseMost command line arguments are included in the pyproject.toml and checking out this branch you can just run
isort --check-only . ruff check --output-format conciseFixing most linting issues is as simple as
isort . ruff check --fixif you trust the auto-formatter!
This PR also extends linting to Dockerfiles and Github actions too.
An excerpt from CONTRIBUTING.md: