FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: Enhance tests for interaction between deviceid and visible devices by EdCaunt · Pull Request #2791 · devitocodes/devito · GitHub

/ devito Public

test: Enhance tests for interaction between deviceid and visible devices - #2791

Merged
FabioLuporini merged 2 commits into
mainfrom
deviceid-errors
Nov 26, 2025
ConversationCommits (2)ChecksFiles changed
Merged

test: Enhance tests for interaction between deviceid and visible devices#2791
FabioLuporini merged 2 commits into
mainfrom
deviceid-errors

Conversation

EdCaunt commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

Also improves errors for invalid combinations.

codecov Bot commented Nov 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.04%. Comparing base (3ce3395) to head (98c6ac1).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
devito/operator/operator.py 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2791      +/-   ##
==========================================
- Coverage   83.04%   83.04%   -0.01%     
==========================================
  Files         248      248              
  Lines       50874    50881       +7     
  Branches     4485     4485              
==========================================
+ Hits        42250    42255       +5     
- Misses       7857     7859       +2     
  Partials      767      767
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.51% <81.81%> (-0.02%) ⬇️
pytest-gpu-nvc-nvidiaX 69.05% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FabioLuporini reviewed Nov 13, 2025
View reviewed changes
Comment thread devito/operator/operator.py Outdated
return visible_devices[logical_deviceid]
except IndexError:
errmsg = (f"A deviceid value of {logical_deviceid} is not valid "
f"with VISIBLE_DEVICES={visible_devices}. Note that "

FabioLuporini Nov 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

since you're at it, fetch the self.platform and prefix it with CUDA_ or ROCM_ accordingly?

also, did you mean "with" or "within" ?

mloubout added API api (symbolics, types, ...) arch jitting, archinfo, ... and removed API api (symbolics, types, ...) labels Nov 14, 2025
FabioLuporini approved these changes Nov 26, 2025
View reviewed changes

FabioLuporini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nice, approving and merging

FabioLuporini merged commit 183bbef into main Nov 26, 2025
39 checks passed
FabioLuporini deleted the deviceid-errors branch November 26, 2025 09:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

FabioLuporini FabioLuporini approved these changes

Assignees

No one assigned

Labels

arch jitting, archinfo, ...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL