FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Tens stagg fix by mloubout · Pull Request #2854 · devitocodes/devito · GitHub

/ devito Public

Tens stagg fix - #2854

Merged
mloubout merged 3 commits into
mainfrom
tens-stagg-fix
Feb 19, 2026
ConversationCommits (3)ChecksFiles changed
Merged

Tens stagg fix#2854
mloubout merged 3 commits into
mainfrom
tens-stagg-fix

Conversation

mloubout commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

Fix issue using Staggering object as input for staggered

mloubout added the API api (symbolics, types, ...) label Feb 19, 2026
mloubout commented Feb 19, 2026
View reviewed changes
Comment thread devito/types/basic.py
return super()._sympify(arg)
except sympy.SympifyError:
# Pure sympy object
return arg._sympy_()

mloubout Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Note: This prevents sympy from forcing some weird type conversion because of

https://github.com/sympy/sympy/blob/16fa855354eb7bcabd3fe10993841e03b1382692/sympy/core/sympify.py#L414

That for example converts EnrichedTuples to sympy's tuples. By using _sympy_ explicitly it makes sure it only convert object with explicity conversion defined (so mostly pure sympy objects or our objects with it defined)

codecov Bot commented Feb 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.96%. Comparing base (df444ea) to head (a60b12a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
devito/types/tensor.py 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2854   +/-   ##
=======================================
  Coverage   78.96%   78.96%           
=======================================
  Files         248      248           
  Lines       50950    50980   +30     
  Branches     4405     4411    +6     
=======================================
+ Hits        40232    40258   +26     
- Misses       9917     9919    +2     
- Partials      801      803    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout merged commit c581d00 into main Feb 19, 2026
42 checks passed
mloubout deleted the tens-stagg-fix branch February 19, 2026 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

FabioLuporini FabioLuporini approved these changes
EdCaunt EdCaunt approved these changes

Assignees

No one assigned

Labels

API api (symbolics, types, ...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL