FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Misc enhancements for lowering of parlang backends by FabioLuporini · Pull Request #2878 · devitocodes/devito · GitHub

/ devito Public

compiler: Misc enhancements for lowering of parlang backends - #2878

Merged
FabioLuporini merged 8 commits into
mainfrom
more-TMA-enhance
Apr 7, 2026
ConversationCommits (8)ChecksFiles changed
Merged

compiler: Misc enhancements for lowering of parlang backends #2878
FabioLuporini merged 8 commits into
mainfrom
more-TMA-enhance

Conversation

FabioLuporini commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

FabioLuporini commented Mar 30, 2026
View reviewed changes
Comment thread devito/ir/support/properties.py
if not exprs:
return properties

# Auto-detect prefetchable Dimensions

FabioLuporini Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

now unused, hence dropping

FabioLuporini commented Mar 30, 2026
View reviewed changes
Comment thread devito/passes/clusters/aliases.py
return schedule.rebuild(*processed, rmapper=rmapper)


def optimize_schedule_maxpar(schedule):

FabioLuporini Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this is 95% just like before, but it now also triggers in some rare cases excited in PRO

FabioLuporini commented Mar 30, 2026
View reviewed changes
Comment thread devito/types/dense.py
def _time_buffering_default(self):
return self._time_buffering and not isinstance(self.save, Buffer)

def _evaluate(self, **kwargs):

FabioLuporini Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mloubout dropped as per your suggestion

codecov Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.33735% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.44%. Comparing base (c189f61) to head (aa388f3).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
devito/ir/iet/efunc.py 57.14% 9 Missing ⚠️
devito/ir/clusters/cluster.py 90.00% 3 Missing ⚠️
devito/types/parallel.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2878      +/-   ##
==========================================
+ Coverage   83.42%   83.44%   +0.02%     
==========================================
  Files         248      248              
  Lines       51262    51311      +49     
  Branches     4431     4428       -3     
==========================================
+ Hits        42765    42819      +54     
- Misses       7735     7736       +1     
+ Partials      762      756       -6
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.79% <81.57%> (+0.03%) ⬆️
pytest-gpu-gcc- 78.05% <84.33%> (+0.02%) ⬆️
pytest-gpu-icx- 77.68% <84.33%> (+0.05%) ⬆️
pytest-gpu-nvc-nvidiaX 69.33% <81.57%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout reviewed Mar 30, 2026
View reviewed changes
Comment thread devito/ir/iet/efunc.py Outdated
libs: tuple = ()

@classmethod
def from_body(cls, body):

mloubout Mar 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does this really need a method? That just EFuncMetadata(body=body)

EdCaunt Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seconded

EdCaunt Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actually, it does improve readability elsewhere, so I'm not entirely opposed

FabioLuporini Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

no, AI garbage, removing

Comment thread devito/ir/iet/efunc.py Outdated

@classmethod
def compose(cls, *items):
items = tuple(i for i in items if i is not None)

mloubout Mar 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why would an item be None?

FabioLuporini Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

AI garbage leftover, removing

Comment thread devito/ir/iet/efunc.py
Comment thread devito/ir/iet/efunc.py
Comment thread devito/ir/iet/efunc.py Outdated


@dataclass(frozen=True)
class EFuncMetadata:

mloubout Mar 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since this clearly looks like it's for an IET pass return, it should be used throughout or at least for the efunc realted ones.

FabioLuporini Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yes, one of the reasons I put it in OSS... but that would be massive changes, I'd rather do it incrementally

also, changing the name to EFuncMeta

EdCaunt reviewed Mar 31, 2026
View reviewed changes
Comment thread devito/ir/iet/efunc.py Outdated
libs: tuple = ()

@classmethod
def from_body(cls, body):

EdCaunt Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seconded

Comment thread devito/types/parallel.py
pass


class ThreadArrive(Fence):

EdCaunt Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this to make use of more sophisticated/granular thread barriers to reduce idle time somewhere?

FabioLuporini Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

pretty much yes

FabioLuporini merged commit 8c448dc into main Apr 7, 2026
42 checks passed
FabioLuporini deleted the more-TMA-enhance branch April 7, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

EdCaunt EdCaunt left review comments
mloubout mloubout approved these changes
JDBetteridge Awaiting requested review from JDBetteridge

Assignees

No one assigned

Labels

compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL