FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Fix topofusion to honour the closest scope by FabioLuporini · Pull Request #2970 · devitocodes/devito · GitHub

/ devito Public

compiler: Fix topofusion to honour the closest scope - #2970

Merged
mloubout merged 2 commits into
mainfrom
hotfix-topofuse-final
Jul 13, 2026
ConversationCommits (2)ChecksFiles changed
Merged

compiler: Fix topofusion to honour the closest scope#2970
mloubout merged 2 commits into
mainfrom
hotfix-topofuse-final

Conversation

FabioLuporini commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

test in PRO

FabioLuporini requested a review from mloubout July 10, 2026 21:23
FabioLuporini force-pushed the hotfix-topofuse-final branch from 5339f4d to 7eac827 Compare July 10, 2026 21:25

codecov Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.55%. Comparing base (0cdfbf5) to head (7d91ac8).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2970      +/-   ##
==========================================
- Coverage   83.55%   83.55%   -0.01%     
==========================================
  Files         257      257              
  Lines       53538    53558      +20     
  Branches     4584     4585       +1     
==========================================
+ Hits        44735    44751      +16     
- Misses       8010     8013       +3     
- Partials      793      794       +1
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.40% <100.00%> (+0.01%) ⬆️
pytest-gpu-gcc- 78.40% <86.15%> (+<0.01%) ⬆️
pytest-gpu-icx- 78.33% <86.15%> (+<0.01%) ⬆️
pytest-gpu-nvc-nvidiaX 69.05% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FabioLuporini force-pushed the hotfix-topofuse-final branch from 7eac827 to 78a5d1f Compare July 13, 2026 12:30

review-notebook-app Bot commented Jul 13, 2026

Copy link
Copy Markdown

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

FabioLuporini commented Jul 13, 2026
View reviewed changes
Comment thread devito/passes/clusters/fusion.py


class Key(tuple):
class Keys(CacheInstances):

FabioLuporini Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this is mostly just a refactoring, essentially to be able to access the last and first properties in the choose_element function later on

FabioLuporini commented Jul 13, 2026
View reviewed changes
Comment thread devito/passes/clusters/fusion.py
return self.c.guards if any(self.c.guards) else None

@cached_property
def syncs(self):

FabioLuporini Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nothing new...

FabioLuporini commented Jul 13, 2026
View reviewed changes
Comment thread devito/passes/clusters/fusion.py
return (self.itintervals, self.guards, self.syncs)

@cached_property
def weak(self):

FabioLuporini Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nothing new...

FabioLuporini force-pushed the hotfix-topofuse-final branch from e3e332f to 7d91ac8 Compare July 13, 2026 15:46
mloubout added the no-pro-trigger Skip the devitopro submodule update on merge label Jul 13, 2026
mloubout merged commit 80f1e1d into main Jul 13, 2026
42 checks passed
mloubout deleted the hotfix-topofuse-final branch July 13, 2026 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mloubout mloubout approved these changes

Assignees

No one assigned

Labels

bug-py no-pro-trigger Skip the devitopro submodule update on merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL