FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Minimize code size reusing efuncs as much as possible by FabioLuporini · Pull Request #2979 · devitocodes/devito · GitHub

/ devito Public

compiler: Minimize code size reusing efuncs as much as possible - #2979

Merged
FabioLuporini merged 5 commits into
mainfrom
tweak-fuse-groups
Jul 27, 2026
ConversationCommits (5)ChecksFiles changed
Merged

compiler: Minimize code size reusing efuncs as much as possible#2979
FabioLuporini merged 5 commits into
mainfrom
tweak-fuse-groups

Conversation

FabioLuporini commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

FabioLuporini requested a review from mloubout July 27, 2026 12:30

codecov Bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.58%. Comparing base (35f711f) to head (204eec4).

Files with missing lines Patch % Lines
devito/passes/iet/orchestration.py 40.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
+ Coverage   83.57%   83.58%   +0.01%     
==========================================
  Files         257      257              
  Lines       53783    53823      +40     
  Branches     4608     4609       +1     
==========================================
+ Hits        44951    44990      +39     
- Misses       8035     8036       +1     
  Partials      797      797
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.53% <68.18%> (+<0.01%) ⬆️
pytest-gpu-gcc- 78.21% <85.45%> (+<0.01%) ⬆️
pytest-gpu-icx- 78.14% <85.45%> (-0.02%) ⬇️
pytest-gpu-nvc-nvidiaX 69.18% <68.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

review-notebook-app Bot commented Jul 27, 2026

Copy link
Copy Markdown

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mloubout approved these changes Jul 27, 2026
View reviewed changes

mloubout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks sane

Comment thread devito/ir/iet/visitors.py
CommCallable: 1
}
return sorted_priority(efuncs, priority)
return sorted(efuncs, key=lambda i: natural_sort_key(i.name))

mloubout Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why i.name the natural_sort_key already calls .name

FabioLuporini Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

r0, r1, r10, r11, ..., r2, r3, ..
instead we now do
r0, r1, r2, r3, ..., r10, r11, ...

FabioLuporini merged commit c9b9cfa into main Jul 27, 2026
61 of 63 checks passed
FabioLuporini deleted the tweak-fuse-groups branch July 27, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mloubout mloubout approved these changes

Assignees

No one assigned

Labels

compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL