data: support assigning a value read by window - #2985
Merged
mloubout merged 2 commits intoAug 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
FabioLuporini
approved these changes
Jul 31, 2026
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 56.00000% with 22 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #2985 +/- ##
==========================================
- Coverage 83.57% 83.56% -0.02%
==========================================
Files 257 257
Lines 53841 53887 +46
Branches 4609 4611 +2
==========================================
+ Hits 44999 45029 +30
- Misses 8044 8061 +17
+ Partials 798 797 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
`Data.__setitem__` already restricts the assigned value to the part of it the calling rank owns. Accept any value exposing a `shape` and slicing, such as a memory mapped array, an HDF5 dataset or a file reader, so that it is only read where it is assigned and never read in full by any rank.
The MPI data initialization notebook covers every right-hand side but the one that is not in memory. Show that a value exposing a `shape` and slicing is assigned like a globally replicated array, each rank reading only the window it owns, and note that `initialize_function` inherits the same behaviour.
Copy link
Copy Markdown
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data.__setitem__ already restricts the assigned value to the part of it the calling rank owns. Accept any value exposing a shape and slicing, such as a memory mapped array, an HDF5 dataset or a file reader, so that it is only read where it is assigned and never read in full by any rank.