FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

misc: Fix oversight regarding SparseTimeFunction index errors by EdCaunt · Pull Request #2989 · devitocodes/devito · GitHub

/ devito Public

misc: Fix oversight regarding SparseTimeFunction index errors - #2989

Merged
mloubout merged 2 commits into
mainfrom
sparse-arg-check
Aug 4, 2026
ConversationCommits (2)ChecksFiles changed
Merged

misc: Fix oversight regarding SparseTimeFunction index errors#2989
mloubout merged 2 commits into
mainfrom
sparse-arg-check

Conversation

EdCaunt commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

EdCaunt requested a review from FabioLuporini August 4, 2026 09:49
EdCaunt self-assigned this Aug 4, 2026

codecov Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.93%. Comparing base (f75f4fc) to head (c0f790a).

Files with missing lines Patch % Lines
devito/types/dense.py 60.00% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (f75f4fc) and HEAD (c0f790a). Click for more details.

HEAD has 27 uploads less than BASE
Flag BASE (f75f4fc) HEAD (c0f790a)
18 1
pytest-gpu-gcc- 6 1
pytest-gpu-icx- 3 0
pytest-gpu-aomp-amdgpuX 1 0
pytest-gpu-nvc-nvidiaX 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2989       +/-   ##
===========================================
- Coverage   83.56%   58.93%   -24.64%     
===========================================
  Files         257      203       -54     
  Lines       53898    34970    -18928     
  Branches     4613     4078      -535     
===========================================
- Hits        45040    20608    -24432     
- Misses       8061    13385     +5324     
- Partials      797      977      +180
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX ?
pytest-gpu-gcc- 55.23% <60.00%> (-22.95%) ⬇️
pytest-gpu-icx- ?
pytest-gpu-nvc-nvidiaX ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout reviewed Aug 4, 2026
View reviewed changes
Comment thread devito/types/dense.py Outdated
i._arg_check(args, s, intervals[i])

if args.options['index-mode'] == 'int32' and \
# SparseTimeFunctions use int64 indexing regardless of index mode

mloubout Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why not move this whole check into Function instead to avoid the is_Sparse/is_regular?

EdCaunt Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It does nominally miss the case that a user specifies a huge SparseFunction, but that seems unlikely, so sure

mloubout merged commit 24444ce into main Aug 4, 2026
42 checks passed
mloubout deleted the sparse-arg-check branch August 4, 2026 18:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

FabioLuporini FabioLuporini approved these changes
mloubout mloubout approved these changes

Assignees

EdCaunt

Labels

bug-py-minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL