Overlapping path check too strict - #685
Merged
spoorcc merged 3 commits intoMar 9, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this frog.
.--._.--.
( O O )
/ . . \
.`._______.'.
/( )\
_/ \ \ / / \_
.~ ` \ \ / / ' ~.
{ -. \ V / .- }
_ _`. \ | | | / .'_ _
>_ _} | | | {_ _<
/. - ~ ,_-' .^. `-_, ~ - .\
'-'|/ \|`-`| File Path | Reviewed |
|---|---|
| dfetch/commands/update.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.
Korbit Guide: Usage and CustomizationInteracting with Korbit
- You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
- You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
- Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings Issue Categories
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
Sorry, something went wrong.
ben-edna
force-pushed
the
spoorcc/issue684
branch
2 times, most recently
from
8e3d85a to
cf4ceb5
Compare
March 7, 2025 16:48
ben-edna
force-pushed
the
spoorcc/issue684
branch
from
cf4ceb5 to
dd8a23b
Compare
March 7, 2025 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #684
Description by Korbit AI
What change is being made?
Relax the overlapping path check in the dfetch update command to ignore scenarios where a real path matches exactly with a destination or does not have any actual parent/child overlapping paths, and add relevant tests to ensure proper functionality.
Why are these changes being made?
The previous implementation erroneously flagged exact path matches as overlaps due to a strict common prefix logic, causing unnecessary warnings and process skips during updates. The new approach accurately identifies true overlapping paths by leveraging Path parent relationships and ensures only genuine overlaps are warned against, thus resolving issue #684 efficiently.