Prefer which node over process.execPath to find out node path - #19
Open
luisdeltoro wants to merge 1 commit into
Open
Prefer which node over process.execPath to find out node path#19luisdeltoro wants to merge 1 commit into
luisdeltoro wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveNodePath() previously prioritised process.execPath, which on Homebrew resolves to a versioned Cellar path (e.g. /opt/homebrew/Cellar/node/25.8.1/bin/node). This path breaks silently after a brew upgrade node, causing the native messaging host to fail to launch and the Chrome extension to lose its connection.
This fix swaps the resolution order so which node (or where node on Windows) is tried first. Package managers like Homebrew, nvm, fnm, and volta all expose a stable symlink (e.g. /opt/homebrew/bin/node) via PATH, which survives upgrades. process.execPath is kept as a fallback for environments where which may not be available.