Fix walkAXTree ignoring children of ignored nodes - #26
Open
danieljohnbyns wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
When an accessibility node is marked as ignored with no name, the code was returning null immediately, which cut off the entire subtree below it. This caused browser_snapshot to return only the root element on real websites like Google. Now it still recurses into children and flattens them: - 0 children -> null - 1 child -> promoted up - multiple children -> wrapped in transparent generic node
Copy link
Copy Markdown
Author
wow, way to call me out for vibe coding too much 😭 |
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)src/lib/snapshot.ts:48
- The promoted wrapper node is constructed without required SnapshotNode fields (name, backendNodeId). This will fail TypeScript type-checking and can also break browser_click/browser_fill when a user selects this UID (backendNodeId becomes undefined). Populate these fields (e.g., empty name and the current node’s backendNodeId).
const uid = nextUid++;
const node: SnapshotNode = { uid, role: "generic", children };
byUid.set(uid, node);
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
browser_snapshot only returned the root element on real websites (e.g. Google, Example Domain). The accessibility tree was being truncated because walkAXTree returned null immediately for any ignored node without a name, cutting off its entire subtree.
Root Cause
Chrome's accessibility tree wraps content in <div> containers with role none and ignored=true. When walkAXTree encountered these nodes, the early return null at line 35 prevented traversal into their children, which contained the actual page content.
Fix
Instead of returning null, the function now:
Testing
Verified with a standalone CDP script and in OpenCode against: