FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: tests failed when `git` is not installed by ycexiao · Pull Request #28 · diffpy/diffpy.apps · GitHub

  1. diffpy
  2. diffpy.apps

Repository navigation

fix: tests failed when git is not installed - #28

Merged
sbillinge merged 5 commits into
diffpy:mainfrom
ycexiao:skipif-no-internet
May 23, 2026
ConversationCommits (5)ChecksFiles changed
Merged

fix: tests failed when git is not installed#28
sbillinge merged 5 commits into
diffpy:mainfrom
ycexiao:skipif-no-internet

Conversation

ycexiao commented May 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • fix: skip agentify tests when git or internet is unavailable
  • feat: ensure git and internet connection
  • fix: use diffpy-app instead of diffpy.app

What problem does this PR address?

The Conda-forge build failed: https://dev.azure.com/conda-forge/84710dde-1620-425b-80d0-4cf5baca359d/_apis/build/builds/1524931/logs/29

  1. Ensure internet connection and git is installed before running agentry to fetch skills.
  2. diffpy.app is not working in macOS system because of the suffix .app. Use diffpy-app instead.

What should the reviewer(s) do?

ycexiao marked this pull request as ready for review May 23, 2026 16:30

codecov Bot commented May 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.14%. Comparing base (5512cb8) to head (974f317).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   94.11%   94.14%   +0.03%     
==========================================
  Files           5        5              
  Lines         187      188       +1     
==========================================
+ Hits          176      177       +1     
  Misses         11       11
Files with missing lines Coverage Δ
tests/test_agentify.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbillinge merged commit c2b88b7 into diffpy:main May 23, 2026
6 checks passed
ycexiao deleted the skipif-no-internet branch October 16, 2026 02:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL