feat: support multiple-contribution refinement - #32
Merged
sbillinge merged 4 commits intoSep 14, 2026
Merged
sbillinge merged 4 commits into
sbillinge merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 96.56% 97.43% +0.87%
==========================================
Files 8 8
Lines 320 429 +109
==========================================
+ Hits 309 418 +109
Misses 11 11
|
Sorry, something went wrong.
ycexiao
commented
Sep 10, 2026
ycexiao
left a comment
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
@sbillinge, it's ready for review.
Sorry, something went wrong.
Comment thread
tests/conftest.py
| return sine_profile | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This fixture has been moved to helper.py as a helper function, where all cmi PDF refinement examples will be located.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Enable diffpy.apps to solve problems like https://github.com/diffpy/diffpy.srfit/blob/main/docs/examples/crystalpdfall.py involves creating recipe with multiple contributions.
What should the reviewer(s) do?