FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add some small capabilities by ycexiao · Pull Request #36 · diffpy/diffpy.apps · GitHub

Repository navigation

feat: add some small capabilities - #36

Merged
sbillinge merged 5 commits into
diffpy:mainfrom
ycexiao:misc_functionalities
Oct 2, 2026
Merged

sbillinge merged 5 commits into
diffpy:mainfrom
ycexiao:misc_functionalities

Conversation

ycexiao commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR address?

  • feat: add a tool to download cif file
  • feat: allow generator to run in parallel
  • feat: allow soft bound restraints

What should the reviewer(s) do?

ycexiao marked this pull request as ready for review September 27, 2026 17:34

codecov Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.24%. Comparing base (b82903c) to head (a03f694).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   98.21%   98.24%   +0.03%     
==========================================
  Files           8        8              
  Lines         615      626      +11     
==========================================
+ Hits          604      615      +11     
  Misses         11       11              
Files with missing lines Coverage Δ
tests/test_refinement_session.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ycexiao commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge, it's ready for review

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would rather we try and get them from iCSD or cod as a first cut, than MP

ycexiao commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge. In that case, we don't need a separate tool for this MVP version diffpy.apps. Claude Code itself can download a cif file from COD out-of-box. Should I add a commit to remove this functionality?

I tried MP because it has finer search interface. COD can also work as good if we add a few skills in the future to better instruct the agent to navigate the database.

Copy link
Copy Markdown
Contributor

MP are calculated and not real structures. I think they can work ok but for political reasons it is better for the community if we load structures that were actually solved from data. People use MP because it is free and has an easy to use interface and not because the underlying data are good.

ycexiao commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Got it. I will remove this tool and add a minimum skill about COD for user experience.

ycexiao commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge, it's ready for review.

I tried add a skill for fetching cif file, but it is more of restricting the flexibility of the way to interact with the agent and adding more maintenance and testing jobs for developers. Since it is already working without any outside tool or skill, I just removed this tool in the latest commit.

sbillinge merged commit f3caa41 into diffpy:main Oct 2, 2026
6 checks passed
ycexiao deleted the misc_functionalities branch October 16, 2026 02:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL