Cookie Cutter + PyPi fix - #132
Merged
sbillinge merged 5 commits intoOct 2, 2024
Merged
sbillinge merged 5 commits into
sbillinge merged 5 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@Sparks29032 I am happy to merge, thanks for the work on this. Normally I don't like merging things with force-pushes in though. Please don't force-push. |
Sorry, something went wrong.
Merged
Copy link
Copy Markdown
Collaborator
Author
|
Got it, I'll consolidate pre-commit next time. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cookiecutter, standard stuff.
Also added contents to pip.txt. This is the same as run.txt except matplotlib-base is changed to matplotlib. This is because matplotlib-base is not available on PyPi, and cannot be pip or pipx (Tom's suggestion) installed. This does not bloat our conda-forge release, which uses run.txt, but it ensures anything building or installing with pip pulls the correct package.
Below is the result without this fix:
