Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (ea41b24) to head (69d45ee).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   97.36%   97.44%   +0.08%     
==========================================
  Files          20       20              
  Lines         947      978      +31     
==========================================
+ Hits          922      953      +31     
  Misses         25       25              

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sparks29032 I am afraid this one has a conflict.

@Sparks29032 I am afraid this one has a conflict.

Ah, probably from me fixing a typo on another PR. Should be resolved now.

I am merging this. I had one comment which is to please make all new tests as pytest tests, not unittest tests. We would gradually over time like to migrate back to pytest tests entirely, but at least, let's not make new unittest tests.

Thanks for merging! I thought these tests were already migrated from unittest to Pytest in #83. These tests seem to follow the Pytest documentation.

Thanks for merging! I thought these tests were already migrated from unittest to Pytest in #83. These tests seem to follow the Pytest documentation.

maybe I didn't check well enough. It looked as if it was indented and part of a class and not a standalone function.

They are classes, but I thought this is supported and encouraged by https://docs.pytest.org/en/stable/getting-started.html. I think I need the python tests presentation lol.

They are classes, but I thought this is supported and encouraged by https://docs.pytest.org/en/stable/getting-started.html. I think I need the python tests presentation lol.

Ah, I see. I don't really see any benefit unless tests are sharing a bunch of code or marks, but mostly I just assumed they were unittest tests (which are typically the only tests we write in classes.....)