FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

style: using new precommit by Tieqiong · Pull Request #116 · diffpy/diffpy.pdffit2 · GitHub

Repository navigation

style: using new precommit - #116

Merged
sbillinge merged 4 commits into
diffpy:mainfrom
Tieqiong:pcmt
Jan 8, 2025
Merged

sbillinge merged 4 commits into
diffpy:mainfrom
Tieqiong:pcmt

Conversation

Tieqiong commented Jan 8, 2025 •
edited by sbillinge
Loading

Copy link
Copy Markdown
Contributor

closes #113

codecov Bot commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (46c5082) to head (3d40d9b).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files           6        6           
  Lines        1261     1261           
=======================================
  Hits         1248     1248           
  Misses         13       13           
Files with missing lines Coverage Δ
tests/test_exceptions.py 99.80% <ø> (ø)
tests/test_pdffit.py 99.76% <ø> (ø)
tests/test_phase_fractions.py 98.70% <ø> (ø)
tests/test_shape_factors.py 99.53% <ø> (ø)
tests/test_version.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Copy Markdown
Contributor

super. I am afraid this became conflicted. But it looks good to merge if you can resolve the conflict.

I added "closes" to the initial comment, but if this doesn't "close" #113 please change the comment to smething more informatoinl such as "addresses" or "handles the prettier part of #113" or whatever the situation is.

This reverts commit b1e6944.

Tieqiong commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

@sbillinge This address the action part of #113. We can close it I think

sbillinge merged commit 24fb526 into diffpy:main Jan 8, 2025
Tieqiong deleted the pcmt branch January 12, 2025 02:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: skpackage v0.1.0: modify .github and .pre-commit-config.yaml. Follow new practices for writing commit/issue and news.rst file

2 participants


Back | FazBrowse Home | New Git URL