FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add option to skip copyright header by Tieqiong · Pull Request #120 · diffpy/diffpy.pdffit2 · GitHub

  1. diffpy
  2. diffpy.pdffit2

Repository navigation

feat: add option to skip copyright header - #120

Merged
sbillinge merged 5 commits into
diffpy:mainfrom
Tieqiong:intro
Jan 12, 2025
ConversationCommits (5)ChecksFiles changed
Merged

feat: add option to skip copyright header#120
sbillinge merged 5 commits into
diffpy:mainfrom
Tieqiong:intro

Conversation

Tieqiong commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

closes #25

@8bitsam @matthewcarbone May I ask if this solve the problem? A use case to skip the copyright:

P = PdfFit(intro=False)

@sbillinge please review, thanks!

codecov Bot commented Jan 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (24fb526) to head (b3b654f).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   98.96%   98.97%           
=======================================
  Files           6        6           
  Lines        1261     1268    +7     
=======================================
+ Hits         1248     1255    +7     
  Misses         13       13
Files with missing lines Coverage Δ
tests/test_pdffit.py 99.76% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

matthewcarbone commented Jan 10, 2025

Copy link
Copy Markdown

I believe this is basically what I had in mind!

sbillinge reviewed Jan 10, 2025
View reviewed changes

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good to me.

Please can you update docstrings and documentation and add a news and I can merge.

sbillinge commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

@Tieqiong this could also use a little test for the intro=false case.

Tieqiong commented Jan 11, 2025

Copy link
Copy Markdown
Contributor Author

@sbillinge please check, thanks

sbillinge reviewed Jan 12, 2025
View reviewed changes

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

sorry, I reviewed this but somehow didn't post the review.....

Comment thread src/diffpy/pdffit2/pdffit.py Outdated
Comment thread src/diffpy/pdffit2/pdffit.py Outdated
Comment thread src/diffpy/pdffit2/pdffit.py Outdated
Comment thread tests/test_pdffit.py
Comment thread tests/test_pdffit.py
sbillinge merged commit 44792a2 into diffpy:main Jan 12, 2025
Tieqiong deleted the intro branch September 19, 2025 01:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revise the way outputs are printed to the console

3 participants

Back | FazBrowse Home | New Git URL