FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: win_py13 SystemError from pytest by Tieqiong · Pull Request #122 · diffpy/diffpy.pdffit2 · GitHub

Repository navigation

fix: win_py13 SystemError from pytest - #122

Merged
sbillinge merged 5 commits into
diffpy:mainfrom
Tieqiong:win_memory
Jan 12, 2025
Merged

sbillinge merged 5 commits into
diffpy:mainfrom
Tieqiong:win_memory

Conversation

Tieqiong commented Jan 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

closes #102 address #96
@sbillinge please check, thanks

This was a tough one... I hate how Windows error messages provide 0 information

Tieqiong changed the title Win memory Win memory (review #121 first please) Jan 12, 2025
Tieqiong changed the title Win memory (review #121 first please) Win memory Jan 12, 2025

codecov Bot commented Jan 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (fdc2e16) to head (d6129aa).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files           6        6           
  Lines        1261     1262    +1     
=======================================
+ Hits         1248     1249    +1     
  Misses         13       13           
Files with missing lines Coverage Δ
tests/conftest.py 73.52% <100.00%> (+0.80%) ⬆️

Tieqiong changed the title Win memory fix: win_py13 SystemError from pytest Jan 12, 2025

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

amazing!!!!!

sbillinge merged commit 913583a into diffpy:main Jan 12, 2025

Copy link
Copy Markdown
Contributor

🦾🦾🦾 incredible!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows Python 3.13 matrix-coverage test fails

3 participants


Back | FazBrowse Home | New Git URL