fix: build sdist failing - #127
Closed
Tieqiong wants to merge 2 commits into
Closed
Tieqiong wants to merge 2 commits into
Tieqiong wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 6 6
Lines 1268 1268
=======================================
Hits 1255 1255
Misses 13 13 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This seemed to work. Do we need to change release-scripts so this new one is run? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge please check, thanks
Apply lazy evaluation to prevents it failing when simply build sdist (workflow attached too to test in diffpy.pdffit2, need to remove before merge)