FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

skpkg: Update rst files, copyright year in license, and `autodoc_mock_import` by cadenmyers13 · Pull Request #139 · diffpy/diffpy.pdffit2 · GitHub

  1. diffpy
  2. diffpy.pdffit2

Repository navigation

skpkg: Update rst files, copyright year in license, and autodoc_mock_import - #139

Merged
sbillinge merged 5 commits into
diffpy:migrationfrom
cadenmyers13:rst-migration
Jun 13, 2025
ConversationCommits (5)ChecksFiles changed
Merged

skpkg: Update rst files, copyright year in license, and autodoc_mock_import#139
sbillinge merged 5 commits into
diffpy:migrationfrom
cadenmyers13:rst-migration

Conversation

cadenmyers13 commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

I reverted back to the old license and just changed the copyright year to 2025 there. Please check the conf.py file to see if doing the mock import for package api rendering is okay. Otherwise I could not get the package API to render locally when i built docs. The rest of the edits here are small formatting things to conform with skpkg and

cadenmyers13 commented Jun 13, 2025
View reviewed changes
Comment thread doc/source/conf.py

autodoc_mock_imports = [
"diffpy.pdffit2.pdffit2",
]

cadenmyers13 Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added this so I could get API to render properly when i built docs.

codecov Bot commented Jun 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (74add76) to head (4f5d7a7).
Report is 9 commits behind head on migration.

Additional details and impacted files 
@@            Coverage Diff             @@
##           migration     #139   +/-   ##
==========================================
  Coverage      98.97%   98.97%           
==========================================
  Files              6        6           
  Lines           1267     1267           
==========================================
  Hits            1254     1254           
  Misses            13       13
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbillinge merged commit edc5bd0 into diffpy:migration Jun 13, 2025

sbillinge commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Very nice! Thanks for the extensive explanations

cadenmyers13 commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

@sbillinge Thanks! Sorry about the licensing mishaps 😆 I'll be more thorough moving forward 🫡

cadenmyers13 commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

@sbillinge I'll test this if they're tutorials then this should be good to merge into main

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL