FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

skpkg: skpkg update without manual edits by stevenhua0320 · Pull Request #149 · diffpy/diffpy.pdffit2 · GitHub

  1. diffpy
  2. diffpy.pdffit2

Repository navigation

skpkg: skpkg update without manual edits - #149

Merged
sbillinge merged 3 commits into
diffpy:migrationfrom
stevenhua0320:scikit-update
Nov 20, 2025
ConversationCommits (3)ChecksFiles changed
Merged

skpkg: skpkg update without manual edits#149
sbillinge merged 3 commits into
diffpy:migrationfrom
stevenhua0320:scikit-update

Conversation

stevenhua0320 commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sbillinge Ready for review. Note that I maintained the max-line-length=115 in the original package so that it would not trigger too many unncessary docstring changes.

codecov Bot commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (e88eb06) to head (1ab04ae).
⚠️ Report is 4 commits behind head on migration.

Additional details and impacted files 
@@            Coverage Diff             @@
##           migration     #149   +/-   ##
==========================================
  Coverage      98.97%   98.97%           
==========================================
  Files              6        6           
  Lines           1267     1267           
==========================================
  Hits            1254     1254           
  Misses            13       13
Files with missing lines Coverage Δ
tests/test_version.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbillinge reviewed Nov 19, 2025
View reviewed changes

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please see comments.

Please confirm that no manual edits were made, or if one or two were made, e.g., adding noqa, please mark them as such with a comment to help me with the reivew.

Nice job.

Comment thread docs/source/conf.py
Comment thread docs/source/conf.py
Comment thread cookiecutter.json Outdated
"maintainer_name": "Simon Billinge",
"maintainer_email": "sb2896@columbia.edu",
"maintainer_github_username": "sbillinge",
"contributors": "Sangjoon Lee, Simon Billinge, Billinge Group members",

sbillinge Nov 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Bob is not a contributor

Comment thread docs/source/conf.py Outdated

stevenhua0320 commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

please see comments.

Please confirm that no manual edits were made, or if one or two were made, e.g., adding noqa, please mark them as such with a comment to help me with the reivew.

Nice job.

I think those noqa is made automatically by package update as I made no edits on those files.

sbillinge merged commit 36c2e74 into diffpy:migration Nov 20, 2025
6 checks passed

sbillinge commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

super! Thanks @stevenhua0320 . Let's move on

This was referenced Nov 22, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL