FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: add `libcblas.dll` to build pypi wheel in windows by ycexiao · Pull Request #155 · diffpy/diffpy.pdffit2 · GitHub

  1. diffpy
  2. diffpy.pdffit2

Repository navigation

fix: add libcblas.dll to build pypi wheel in windows - #155

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
ycexiao:win-libcblas
Nov 24, 2025
ConversationCommits (1)ChecksFiles changed
Merged

fix: add libcblas.dll to build pypi wheel in windows#155
sbillinge merged 1 commit into
diffpy:mainfrom
ycexiao:win-libcblas

Conversation

ycexiao commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR address?

Close #133

What should the reviewer(s) do?

To validate the built wheel:

python -m build
pip install .\dist\diffpy_pdffit2-0.0.1-cp313-cp313-win_amd64.whl --force-reinstall
python -c "import diffpy.pdffit2; print(diffpy.pdffit2.__version__)"

ycexiao marked this pull request as ready for review November 24, 2025 00:11

ycexiao commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

@sbillinge @stevenhua0320, it's ready for review.

codecov Bot commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (4773715) to head (9d752a7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files           6        6           
  Lines        1270     1270           
=======================================
  Hits         1257     1257           
  Misses         13       13
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

stevenhua0320 commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

@ycexiao It looks good to me, thanks for help!
@sbillinge ready for review, after this is tested on your local windows and if it is passed, we can start on the pre-release process.

sbillinge merged commit b657883 into diffpy:main Nov 24, 2025
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing cblas.dll in the Windows pypi wheel

3 participants

Back | FazBrowse Home | New Git URL