FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

skpkg: run package update on the repository and support python 3.14 while dropping 3.11 by zmx27 · Pull Request #162 · diffpy/diffpy.pdffit2 · GitHub

  1. diffpy
  2. diffpy.pdffit2

Repository navigation

skpkg: run package update on the repository and support python 3.14 while dropping 3.11 - #162

Merged
sbillinge merged 4 commits into
diffpy:migrationfrom
zmx27:package-update
Mar 26, 2026
ConversationCommits (4)ChecksFiles changed
Merged

skpkg: run package update on the repository and support python 3.14 while dropping 3.11#162
sbillinge merged 4 commits into
diffpy:migrationfrom
zmx27:package-update

Conversation

zmx27 commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #145

zmx27 commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review. I also ran pre-commit with the newly added docformatter lines into the repo.

sbillinge reviewed Mar 26, 2026
View reviewed changes

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great. Please see comments

Comment thread docs/source/conf.py
"m2r2",
]

autodoc_mock_imports = [

sbillinge Mar 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am guessing we may need to keep this unless there is a reason you think not

Comment thread docs/source/conf.py
# |version| and |release|, also used in various other places throughout the
# built documents.

fullversion = version(project)

sbillinge Mar 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please check that full version is getting defined somewhere

zmx27 Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, fullversion is being defined at the top of the file in the following code snippet:

# Attempt to import the version dynamically from GitHub tag.
try:
    fullversion = version("diffpy.pdffit2")
except Exception:
    fullversion = "No version found. The correct version will appear in the released version."  # noqa: E501

Comment thread pyproject.toml
[tool.codespell]
exclude-file = ".codespell/ignore_lines.txt"
ignore-words = ".codespell/ignore_words.txt"
skip = "*.cif,*.dat,*.cc,*.h"

sbillinge Mar 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We probably want to keep the .cc and .h here

sbillinge Mar 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this line deleted? We don't want it?

zmx27 commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review.

codecov Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (45d87f5) to head (94cabbe).
⚠️ Report is 5 commits behind head on migration.

Additional details and impacted files 
@@            Coverage Diff             @@
##           migration     #162   +/-   ##
==========================================
  Coverage      98.97%   98.97%           
==========================================
  Files              6        6           
  Lines           1270     1270           
==========================================
  Hits            1257     1257           
  Misses            13       13
Files with missing lines Coverage Δ
tests/test_exceptions.py 99.80% <ø> (ø)
tests/test_pdffit.py 99.76% <ø> (ø)
tests/test_shape_factors.py 99.53% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbillinge merged commit 85eeade into diffpy:migration Mar 26, 2026
6 checks passed
sbillinge mentioned this pull request Mar 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL