Repository navigation
fix copy-paste shortcut on the phase-configuration panel #29
Description
The atom-list in the Phase Configuration panel has copy/paste functionality in the right-click context menu. The standard copy/paste shortcuts <ctrl-c>, <ctrl-v> however apply to the current phase node in the fit-tree even if it is the atom-list that is in focus.
Proposed solution: check what is in focus when handling the Copy / Paste shortcut keys.
Metadata
Metadata
Assignees
Labels
No labels
Activity
sbillinge commented on Nov 28, 2017
This may be related to #14 so perhaps they should be handled together @chiahaoliu @pavoljuhas ? It would also be good for @dragonyanglong to be looped in since he will be working on PDFgui2.0
pavoljuhas commented on Nov 28, 2017
The descriptions are similar, but I think it is better to keep them as separate tasks. The "Phase Configuration" already has copy/paste functionality in, so this issue just needs a proper handling of shortcut keys. The Parameters page to my knowledge does not have copy/paste functions at all. I suggest Tim @chiahaoliu and I do this issue first and then proceed to #14.
sbillinge commented on Nov 29, 2017
pavoljuhas commented on Jan 2, 2018
@chiahaoliu - Happy New Year Tim! Was there any progress with this task?
I'd like to do a minor release soon so we can have other improvements (working bugreport) out in the Anaconda version.
chiahaoliu commented on Jan 3, 2018
@pavoljuhas Happy new year!
Actually I briefly started looking into this issue but got confused somehow. Maybe you can help me with the context of this issue :)
I looked into the PhaseConfigurationPanel class and I found in the onKey method there is no clause to capture the <ctrl+c> and <ctrl+v> events. However, there is copy-paste method in the right-click event as you mentioned.
Would this be the origin of the problem? (since shortcut is not handled).
Thanks.
SiebevanderVeer commented on Feb 21, 2025
Hi PDFgui development team. I am not sure if the topic here, i.e. copy pasting of parameters, is also discussed elsewhere, but I wanted to ask if this issue will be resolved for PDFgui 3.1.0? I've been told that for the older version of PDFgui, this was an option and it would be really convenient if it could also be implemented for newer versions.
Thanks and best,
Siebe
sbillinge commented on Mar 4, 2025
Thanks for posting @SiebevanderVeer . This issue relates to a bug, but from your post it sounds like you are requesting a convenience feature. We did not remove copy-paste from the 3.1.0 version, it should be working as it did before. Is that not the case?
SiebevanderVeer commented on Mar 5, 2025
Hi @sbillinge, thanks for the reply. Copying and pasting in the atom list has not worked for me with any version of PDFgui2. I get the same result as reported in the original post, i.e. that a copy action in PDFgui always results in copying the currently selected/active phase.
I don't exactly remember which version I started with, but it was somewhere mid-2024. I've been told by another user that it did work in earlier versions of PDFgui.
sbillinge commented on Mar 12, 2025
OK, Thanks @SiebevanderVeer , we will keep this alive and see if we can fix it for the next release.