Repository navigation
Flake8v3 - #139
Closed
cadenmyers13 wants to merge 7 commits into
Closed
Flake8v3#139cadenmyers13 wants to merge 7 commits into
cadenmyers13 wants to merge 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sbillinge
reviewed
Jul 31, 2024
sbillinge
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
please see the inline comment. Most of these lamdas -> functions should be private actually, if you could quickly refactor them all.
Sorry, something went wrong.
Comment thread
src/diffpy/pdfgui/gui/temperatureseriespanel.py
| self.fillList() | ||
| return | ||
|
|
||
| def create_filename_order(self): |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why are you wrapping this in a function? It doesn't seem like it needs to be.
Sorry, something went wrong.
Comment thread
src/diffpy/pdfgui/gui/temperatureseriespanel.py
| self.filename_order = dict(zip(filenames, range(len(filenames)))) | ||
| return | ||
|
|
||
| def filename_sortkey(self, tf): |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
when we do turn lambdas into functions, mostly they should be private functions (just put an underscore at the beginning of the name).
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch passes all tests