Repository navigation
cookiecutter: modified files pt2 - #154
cadenmyers13 wants to merge 5 commits into
Conversation
Sorry, something went wrong.
sbillinge
left a comment
There was a problem hiding this comment.
please see inline comments.
Sorry, something went wrong.
|
|
||
| control = PDFGuiControl() | ||
| control.load("../../tests/testdata/ni.ddp") | ||
| control.load("src/diffpy/pdfgui/tests/testdata/ni.ddp") |
There was a problem hiding this comment.
did you test this? It is unlikely to work because this is a relative file-path.
Sorry, something went wrong.
| from importlib import resources | ||
|
|
||
| from pkg_resources import Requirement, resource_filename | ||
| from pkg_resources import Requirement |
There was a problem hiding this comment.
I think pkg_resources is deprecated so we want to get rid of this. I would put pkg_resources fixes on a separate PR tbh.
Sorry, something went wrong.
|
|
||
| # Resolve APPDATADIR base path to application data files. | ||
| _mydir = os.path.abspath(resource_filename(__name__, "")) | ||
| _mydir = os.path.abspath(str(resources.files(__name__).joinpath(""))) |
There was a problem hiding this comment.
whenever we touch lines of code that do path munging, switch the code to using pathlib.Path. Then do it for the full module. This also on a separate PR because it will be harder to merge.
Sorry, something went wrong.
@sbillinge second half of commits for modified files