FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

replace danse links by Tieqiong · Pull Request #202 · diffpy/diffpy.pdfgui · GitHub

  1. diffpy
  2. diffpy.pdfgui

Repository navigation

replace danse links - #202

Closed
Tieqiong wants to merge 1 commit into
diffpy:mainfrom
Tieqiong:danse
ConversationCommits (1)ChecksFiles changed
Closed

replace danse links#202
Tieqiong wants to merge 1 commit into
diffpy:mainfrom
Tieqiong:danse

Conversation

Tieqiong commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

closes #186

sbillinge reviewed Aug 28, 2024
View reviewed changes

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please see inline

Comment thread doc/manual/pdfgui.texinfo
and functions that it returns, please see the API
documentation for diffpy.pdfgui at
@url{http://docs.danse.us/diffraction/diffpy.pdfgui/}.
@url{https://www.diffpy.org/diffpy.pdfgui/api/diffpy.pdfgui.html}.

sbillinge Aug 28, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this should be https://diffpy.github.io/diffpy.pdfgui when everything is working, something like that. We don't want to resolve to a file on github but to published documentation.

Tieqiong Aug 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, will change, also see discussion in #203

sbillinge commented Dec 16, 2024

Copy link
Copy Markdown
Contributor

@Tieqiong when you have time, please could you revisit this one and we can get it merged.

Tieqiong mentioned this pull request Dec 26, 2024
Merged
Tieqiong mentioned this pull request Jan 14, 2025
Closed

Tieqiong commented Jan 14, 2025

Copy link
Copy Markdown
Contributor Author

closing, replaced by #239 and #247

Tieqiong closed this Jan 14, 2025
Tieqiong deleted the danse branch January 16, 2025 05:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace DANSE links

2 participants

Back | FazBrowse Home | New Git URL