FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use `matplotlib` instead of `matplotlib-base` in `run.txt` - discussion on assign packages by bobleesj · Pull Request #220 · diffpy/diffpy.pdfgui · GitHub

  1. diffpy
  2. diffpy.pdfgui

Repository navigation

Use matplotlib instead of matplotlib-base in run.txt - discussion on assign packages - #220

Closed
bobleesj wants to merge 3 commits into
diffpy:mainfrom
bobleesj:patch-1
ConversationCommits (3)ChecksFiles changed
Closed

Use matplotlib instead of matplotlib-base in run.txt - discussion on assign packages#220
bobleesj wants to merge 3 commits into
diffpy:mainfrom
bobleesj:patch-1

Conversation

bobleesj commented Oct 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest rc version of pdfgui contains run.txt which contains matplotlib-base.

This PR fixes the following:

pip install diffpy.pdfgui==3.1.0rc5

ERROR: Could not find a version that satisfies the requirement matplotlib-base (from diffpy-pdfgui) (from versions: none)
ERROR: No matching distribution found for matplotlib-base

Closes #207 - tested that run.txt dependencies are installed during pip install.

bobleesj marked this pull request as ready for review October 2, 2024 13:26

bobleesj commented Oct 2, 2024

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review

bobleesj mentioned this pull request Oct 2, 2024
Merged

bobleesj commented Oct 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sbillinge will make a new general PR based on today's discussion

  • conda.txt for all conda dependencies for our CI to run conda install --file requirements/...
  • pip.txt for all pip dependencies required for pip install <package>

bobleesj closed this Oct 2, 2024

sbillinge commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

I am afraid this means we will have to update all documentation and readmes as well. Not sure if it is more work to share this around or just do it. In general, it might be good to assigne packages to people, and whenever there is a task like this, we send a general slack saying "please update your packages by Friday" and everyone knows what it means. We will have to assign packages to new people when old people leave....

bobleesj commented Oct 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sbillinge Indeed, these are the current chefs now:

  • diffpy.pdfmorph | Andrew
  • diffpy.srmise | Steven
  • diffpy.labpdfproc | Yucong
  • diffpy.fourigui | Caden
  • diffpy.utils |
  • diffpy.structure |
  • diffpy.pdfgui |
  • diffpy.srfit |
  • diffpy.snmf |
  • bg-mpl-stylesheets |
  • †diffpy.pdffit2 |
  • †diffpy.srreal |
  • diffpy.nmf_mapping |

Next week, perhaps we can sit down and assign each member have 2 packages (also include Tieqiong) and also have new members take on one or two for training as well?

bobleesj changed the title Use matplotlib instead of matplotlib-base in run.txt Use matplotlib instead of matplotlib-base in run.txt - discussion on assign packages Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check dependency installation section in pyproject.toml

2 participants

Back | FazBrowse Home | New Git URL