Repository navigation
Re-cookiecut: implement codecov, install pdffit2 rc, limit to py3.12 - #235
Merged
sbillinge merged 9 commits intoDec 7, 2024
Merged
sbillinge merged 9 commits into
sbillinge merged 9 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #235 +/- ##
===========================================
+ Coverage 55.86% 95.11% +39.25%
===========================================
Files 96 23 -73
Lines 11202 1126 -10076
===========================================
- Hits 6258 1071 -5187
+ Misses 4944 55 -4889 |
Sorry, something went wrong.
bobleesj
commented
Dec 7, 2024
Comment thread
.github/workflows/tests-on-pr.yml
| run: | | ||
| conda install --file requirements/test.txt | ||
| conda install wxpython diffpy.utils matplotlib-base | ||
| pip install diffpy.pdffit2==1.4.4rc6 |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Since we are testing pdfgui with pdffit rc, we conda install wxpython, diffpy.utils, and matplotlib-base
and then we pip install pdffit2 rc
Once we have pdfgui tested with pdffit2 rc, we could try to find an approach to use the reusable workflow? @sbillinge
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Nice! |
Sorry, something went wrong.
This was referenced Dec 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #232 - add codecov report in PR
Closes #231 - implement codespell
Closes #230 - add requires-python in pyproject.toml
Closes #236 - fix spelling suggested by Codespell