FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: released user manual img not showing by Tieqiong · Pull Request #248 · diffpy/diffpy.pdfgui · GitHub

Repository navigation

fix: released user manual img not showing - #248

Closed
Tieqiong wants to merge 7 commits into
diffpy:mainfrom
Tieqiong:doc
Closed

Tieqiong wants to merge 7 commits into
diffpy:mainfrom
Tieqiong:doc

Conversation

Tieqiong commented Jan 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sbillinge I can't deploy documentation so I can't really test if this works, but I'm 60% sure...

codecov Bot commented Jan 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (5e5cc7f) to head (2c9f268).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          23       23           
  Lines        1126     1126           
=======================================
  Hits         1071     1071           
  Misses         55       55           

Copy link
Copy Markdown
Contributor

@Tieqiong this is conflicted now I am afraid.

Is there a way to test this? Maybe just merge this and open an issue to double check it when we do the rc release, and attach that issue to the full-release milestone?

Copy link
Copy Markdown
Contributor

To test doc, @Tieqiong you could deploy docs by workflow dispatch in your forked repo.

Copy link
Copy Markdown
Contributor Author

closing, replaced by #254

Tieqiong closed this Jan 16, 2025
Tieqiong deleted the doc branch January 16, 2025 07:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL