Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (1cb1890) to head (f23184b).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   95.11%   95.10%   -0.02%     
==========================================
  Files          23       23              
  Lines        1126     1123       -3     
==========================================
- Hits         1071     1068       -3     
  Misses         55       55              

@sbillinge please check, thanks

This is not a fix on the actual code. This is for fixing a buggy test code (bug on test code not on the actual code) that fails all the windows matrix test.

The problem is on test_LogoClicks in test_aboutdialog.py. This test is to simulate user interactions with the About tag in GUI and verify clicking on various logo buttons leads to the expected url. The modified context manager overridewebbrowser is in testutils but used in test_LogoClicks. It try to temporarily replaces the normal behavior of opening a web browser by calling set_url which captures the url that pdfgui tries to open without actually opening the browser.

The reason why the test was not passing only on Windows is because webbrowser.open work differently on windows, which returns different instance for subsequent calls. Thus the override in the old test code doesn't stick to the right instance as the code that actually calls webbrowser.open ends up using a different unchanged controller.

again, thanks @Tieqiong for figuring this out (this bug was really "bugging" me for a long time!) but also for the detailed explanation!