Repository navigation
refactor: ending support for WX3 - #259
Merged
sbillinge merged 3 commits intoJan 18, 2025
Merged
sbillinge merged 3 commits into
sbillinge merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 23 23
Lines 1123 1123
=======================================
Hits 1068 1068
Misses 55 55 |
Sorry, something went wrong.
sbillinge
reviewed
Jan 17, 2025
sbillinge
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks good to me. Is there a way to check that it didn't break anything?
Sorry, something went wrong.
Comment thread
news/wx3.rst
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@sbillinge I'm not sure if there's any other ways except the matrix CI test and some manual pre-release tests... At least I played with it for a while and didn't see anything unusual. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #144
@sbillinge please check, thanks