FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: fix TypeError when using Nyquist interp by Tieqiong · Pull Request #268 · diffpy/diffpy.pdfgui · GitHub

Repository navigation

fix: fix TypeError when using Nyquist interp - #268

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
Tieqiong:interp_xtype
Feb 6, 2025
Merged

sbillinge merged 1 commit into
diffpy:mainfrom
Tieqiong:interp_xtype

Conversation

Tieqiong commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

@sbillinge please check, thanks

Previously when using nyquest grid it will give error like

TypeError: '<' not supported between instances of 'list' and 'float'

which is because the sampler function in diffpy.utils only accept ndarray while pdfgui provide array_like (list) type

codecov Bot commented Feb 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (9a0cf41) to head (8b3c51f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          23       23           
  Lines        1123     1123           
=======================================
  Hits         1068     1068           
  Misses         55       55           

sbillinge merged commit ce00937 into diffpy:main Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL