FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

skpkg: recut the package using latest skpkg-version by stevenhua0320 · Pull Request #296 · diffpy/diffpy.pdfgui · GitHub

Repository navigation

skpkg: recut the package using latest skpkg-version - #296

Merged
sbillinge merged 4 commits into
diffpy:mainfrom
stevenhua0320:skpkg-update
Feb 18, 2026
Merged

sbillinge merged 4 commits into
diffpy:mainfrom
stevenhua0320:skpkg-update

Conversation

Copy link
Copy Markdown
Contributor

@sbillinge ready to review. Mostly are made by the skpkg update command with minimal fix. In this PR:

  1. Because we don't want to change license, I maintained the same one as before. And also the same for the license starting date. I manually add the starting year of license.
  2. I realized that in the matlab code, one of the parameters should be called alpha instead of alph. Therefore, I changed that to the correct name.
  3. To make it convenient to update, since originally we have the doc instead of docs, I first did a rename of the folder so that package update would identify the structure and do the update for the docs folder properly.
  4. If this could be merged, I would do the pytest stuff to update the deprecation thing in the next PR.

Copy link
Copy Markdown
Contributor Author

@sbillinge We fail on this because right now we haven't pull diffpy.pdffit2 to python 3.14. We need to wait for Zhiming for some time and then rerun the test so that we could see if it would pass.

sbillinge merged commit 93a7136 into diffpy:main Feb 18, 2026
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL