Repository navigation
build: remove deprecation usage of wxpython to make build successfully - #304
Open
stevenhua0320 wants to merge 1 commit into
Open
stevenhua0320 wants to merge 1 commit into
stevenhua0320 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #304 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 23 23
Lines 1123 1123
=======================================
Hits 1068 1068
Misses 55 55
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@sbillinge This fails the pre-commit hook, but it still wires with the old hooks. I saw there is a PR ongoing about the pre-commit update #302, so it might be good to first close that one by @stevengeorge128 and then revist once the hook is fixed. |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #303 @sbillinge ready to review. In this PR:
We removed the deprecative usage of wxpython and the default size for the gui button is 16 by 16, so we could safely comment the lines affected right now.