Repository navigation
deprecate: deprecate setProfile - #144
Merged
sbillinge merged 5 commits intoFeb 6, 2026
Merged
sbillinge merged 5 commits into
sbillinge merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Looks great! Let's merge when tests pass. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@cadenmyers13 this is successfully loading _deprecator now, but there is a bug in this PR because we changed the name of deprecation_message to build_deprecation_message. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@sbillinge ah nice catch, thanks. this is good now |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 69.36% 69.36%
=======================================
Files 25 25
Lines 3457 3457
=======================================
Hits 2398 2398
Misses 1059 1059
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First shot test following my instructions. everything seemed to work as desired. This will fail until diffpy.utils 3.7.0 is released