Repository navigation
deprecate: addParameter, newParameter, and removeParameter deprecation - #214
Merged
sbillinge merged 2 commits intoSep 16, 2026
Merged
sbillinge merged 2 commits into
sbillinge merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
addParameter, newParameter and removeParameter were the public spelling of RecipeOrganizer's private _add_parameter/_new_parameter/ _remove_parameter, exposed as bare class-level aliases. Point the snake_case names at those aliases instead and add forwarding @deprecated shims for the camelCase names, matching how addParameterSet and removeParameterSet were handled in the same file. Internal callers in fitbase, pdf, sas and structure move to the new names so core no longer warns at itself. BaseSpaceGroupParameters.addParameter in structure/sgconstraints.py is deliberately untouched: it is a RecipeContainer, not a ParameterSet, so it neither inherits nor reaches these accessors, and renaming it belongs with the rest of the structure subpackage renames. This unblocks the structure and sas subpackage renames, which could not move off addParameter while it was core's only public spelling. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #214 +/- ##
===========================================
+ Coverage 71.63% 82.51% +10.88%
===========================================
Files 25 27 +2
Lines 3437 4130 +693
===========================================
+ Hits 2462 3408 +946
+ Misses 975 722 -253
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addParameter, newParameter and removeParameter were not updated to snake case in the last release. This PR updates their names to snake case