Repository navigation
fix: clean up core srfit before the subpackage split - #217
Merged
sbillinge merged 1 commit intoOct 8, 2026
Merged
sbillinge merged 1 commit into
sbillinge merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fix the SASProfile set_observed_profile override that core no longer called, remove the undeclared six dependency and its Python 2 branches, and load test_fitrecipe data with ProfileParser instead of PDFParser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #217 +/- ##
===========================================
+ Coverage 71.63% 82.71% +11.08%
===========================================
Files 25 27 +2
Lines 3437 4178 +741
===========================================
+ Hits 2462 3456 +994
+ Misses 975 722 -253
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the SASProfile set_observed_profile override that core no longer called, remove the undeclared six dependency and its Python 2 branches, and load test_fitrecipe data with ProfileParser instead of PDFParser.
This PR does three things: