Repository navigation
fix: Replaced deprecated setScatteringFactorTableByType with scatteringfactortable - #225
Merged
sbillinge merged 2 commits intoOct 13, 2026
Merged
sbillinge merged 2 commits into
sbillinge merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…rator diffpy.srreal deprecates setScatteringFactorTableByType in favor of assigning the scatteringfactortable property, which accepts the same type strings. Add tests for setScatteringType covering X, N, E, a registered long name and an unknown type. Closes diffpy#137 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep only the update of the reference calculation in testGenerator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #225 +/- ##
===========================================
+ Coverage 71.63% 85.13% +13.50%
===========================================
Files 25 43 +18
Lines 3437 4751 +1314
===========================================
+ Hits 2462 4045 +1583
+ Misses 975 706 -269
... and 21 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137
diffpy.srreal deprecates setScatteringFactorTableByType in favor of assigning the scatteringfactortable property, which accepts the same type strings.