Repository navigation
dep: deprecate diffpy.srfit.structure in favor of diffpy.cmistructure - #236
Merged
sbillinge merged 4 commits intoOct 23, 2026
Merged
sbillinge merged 4 commits into
sbillinge merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cadenmyers13
commented
Oct 21, 2026
Comment thread
tests/deprecated/test_structure_deprecations.py
| def nacl_structure(): | ||
| lattice = Lattice(5.6, 5.6, 5.6, 90, 90, 90) | ||
| atoms = [Atom("Na", [0, 0, 0]), Atom("Cl", [0.5, 0.5, 0.5])] | ||
| return Structure(atoms, lattice=lattice) |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This fixture is left here because it is only used in the deprecation tests so we want to remove it when all the tests are removed. If we don't, this will hang around in conftest.py unused
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@sbillinge ready for review. deprecation of diffpy.srfit.structure |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 85.00000% with 9 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 84.95% 84.97% +0.01%
==========================================
Files 44 45 +1
Lines 4886 4945 +59
==========================================
+ Hits 4151 4202 +51
- Misses 735 743 +8
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecating diffpy.srfit.structure in favor of diffpy.cmistructure.
This PR emits the deprecation warning on import:
and if a function is called:
The attribute stru is also deprecated: